Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert disabled_by to DeviceEntryDisabler on load #63944

Merged
merged 7 commits into from Jan 12, 2022

Conversation

agners
Copy link
Member

@agners agners commented Jan 11, 2022

Breaking change

Proposed change

Fix string comparison for newly introduced StrEnum.

String comparison should be done using == or !=. is/is not compares addresses of object. It works sometimes due to string de-duplication, but its not a proper comparison for strings.

Convert disabled_by to DeviceEntryDisabler on load.

Found the problem while debugging issue #63800. This addresses all instances I found in #60239 and #58646.

cc @scop @Adminiuga

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (deconz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @corneyl, mind taking a look at this pull request as it has been labeled with an integration (picnic) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@agners agners changed the title Fix string comparisons Convert disabled_by to DeviceEntryDisabler on load Jan 12, 2022
Dev automation moved this from Needs review to Reviewer approved Jan 12, 2022
@agners agners added this to the 2021.12.10 milestone Jan 12, 2022
@balloob balloob merged commit 42706f7 into home-assistant:dev Jan 12, 2022
Dev automation moved this from Reviewer approved to Done Jan 12, 2022
@frenck
Copy link
Member

frenck commented Jan 12, 2022

Nice catch! Thanks all!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Devices stay disabled after re-enabling integrations
6 participants